Skip to content

refactor(perps): review skill composes the perps library instead of carrying knowledge copies - #159

Merged
abretonc7s merged 2 commits into
mainfrom
feat/perps-review-library
Sep 14, 2026
Merged

abretonc7s merged 2 commits into
mainfrom
feat/perps-review-library

Conversation

@abretonc7s

Copy link
Copy Markdown
Contributor

Summary

Single source for perps review knowledge: MetaMask/experimental-metamask-recipe-perps (review/antipatterns.md, review/parity.md, review/shared-packages.md, owned-paths.json, docs/knowledge/), see MetaMask/experimental-metamask-recipe-perps#18. The harness composes it (mm-harness help review --domain perps, mm-harness review checklist --domain perps, MetaMask/experimental-metamask-harness#254).

  • perps-review-pr: rewritten as a thin skill (target, guide, checklist, parity, verdict, --since re-review, optional cross-review). It carries no knowledge and no repos/ overlay.
  • domains/perps/knowledge/ removed (nine files, all moved to the library).
  • perps-breakdown-tickets, perps-write-ticket, perps-validate-multiproject: references point at the library files instead of the installed knowledge/ copy.
  • CHANGELOG entry.

node --test test/*.test.mjs: 61 pass. lint-skill-entry: 0 errors.

Note for installs

tools/install already removes a stale knowledge/ directory beside an installed skill when the domain no longer ships one, so re-running the install in a product checkout cleans the copies.

abretonc7s and others added 2 commits September 14, 2026 10:41
…arrying knowledge copies

perps-review-pr becomes a thin wrapper over mm-harness review checklist
--domain perps. The perps knowledge files now live only in
MetaMask/experimental-metamask-recipe-perps (review/, docs/knowledge/),
so domains/perps/knowledge/ and the skill's repos/ overlay are removed
and the sibling perps skills reference the library.
Resolve CHANGELOG.md conflict by keeping main's Changed entries and the
perps review-library refactor note from this branch.

Co-authored-by: Cursor <cursoragent@cursor.com>
@abretonc7s
abretonc7s merged commit bf20f0c into main Sep 14, 2026
28 checks passed
@abretonc7s
abretonc7s deleted the feat/perps-review-library branch September 14, 2026 13:04
matallui added a commit that referenced this pull request Sep 15, 2026
…-description-over-1024

* origin/main:
  feat: add navigation skill with MetaMask Mobile overlay (#148)
  feat: add feature-flags skill with MetaMask Mobile overlay (#147)
  feat: add analytics skill with MetaMask Mobile overlay (#140)
  feat: Adds `observability` domain with Sentry, Tempo, telemetry cost control skills (#76)
  refactor(perps): review skill composes the perps library instead of carrying knowledge copies (#159)

# Conflicts:
#	README.md
matallui added a commit that referenced this pull request Sep 15, 2026
…-description-over-1024

* origin/main:
  feat: add navigation skill with MetaMask Mobile overlay (#148)
  feat: add feature-flags skill with MetaMask Mobile overlay (#147)
  feat: add analytics skill with MetaMask Mobile overlay (#140)
  feat: Adds `observability` domain with Sentry, Tempo, telemetry cost control skills (#76)
  refactor(perps): review skill composes the perps library instead of carrying knowledge copies (#159)

# Conflicts:
#	README.md
@georgewrmarshall georgewrmarshall mentioned this pull request Nov 17, 2026
georgewrmarshall added a commit that referenced this pull request Nov 18, 2026
## Release `@metamask/skills` 0.4.0

This is the release candidate for **0.4.0**, a minor release that brings
in everything merged to `main` since
[v0.3.1](https://github.com/MetaMask/skills/releases/tag/v0.3.1) (66
PRs). See `CHANGELOG.md` for the full list with PR links.

### Highlights

**New domains**
- `observability`: Sentry, Tempo and telemetry cost-control skills
- `performance`: measurement, anti-pattern scanning and React Compiler
triage
- `typescript`: authoring and migration skills
- `platform`: Extension runtime architecture and failure modes

**New skills**
- Mobile planning (`planning`, `planning-spec`, `jira-brief`), now
stable `base` skills for Mobile and Extension
- `analytics`, `feature-flags`, `navigation` and `selector-patterns`,
each with a repo-agnostic base and a Mobile overlay
- A PR review base skill, generated Perps review checklists,
`notifications-category-sync`, a profiling regression proposal skill and
activity mapper guidance
- Recipe planning and cooking skills, pinned to a single mm-harness
version with an install-time version check

**UI development and content**
- A shared, MCP-free `ui-development` baseline for looking up MetaMask
Design System components, with thin Mobile and Extension overlays
- Content guidelines with shared rules plus Mobile and Extension
overlays, which now also apply when existing strings are edited

**Testing**
- `visual-testing` and `mobile-visual-testing` updated for
`@metamask/client-mcp-core` 0.14.0 and `@metamask/device-mcp` 0.8.0
- Component-view flake rules and Appium stability patterns added to
`mobile-testing`

**Installer / CLI**
- Explicit-only skill invocation, preserved repository overlays and
pruning of retired skill names during sync
- Syncs of each shared skill source run one at a time, so concurrent
syncs can't collide during a Git fetch
- Skill descriptions over the 1024-character catalog limit are shortened

### Changelog

The auto-generated `[0.4.0]` section has been rewritten into Added,
Changed and Fixed entries, written for consumers. It replaces the
`Uncategorized` commit titles, removes duplicates and adds the PRs that
were missing (#159, #183, #212 and #213).

### Release steps

1. Approve the pending workflow run so CI runs on this PR, including
`yarn lint:changelog --rc`, the tests and `yarn pack:dry-run`.
2. Get a review from @MetaMask/extension-platform or
@MetaMask/mobile-platform.
3. Squash-merge, keeping github-actions as the commit author. That's
what lets **Publish Release** run.
4. @metamask-npm-publishers approve the `npm-publish` environment. Then
`@metamask/skills@0.4.0` is published to npm, and the `v0.4.0` GitHub
release and tag are created.

---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: George Marshall <george.marshall@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants